From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] discontig.c
Date: Thu, 10 Jun 2004 20:00:20 +0000 [thread overview]
Message-ID: <200406101300.20258.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <40C87CF0.7070206@hp.com>
On Thursday, June 10, 2004 11:10 am, David Mosberger wrote:
> >>>>> On Thu, 10 Jun 2004 11:23:28 -0400, Robert Picco
> >>>>> <Robert.Picco@hp.com> said:
>
> Rob> Hi David and Andrew: I found a problem with HP NUMA
> Rob> configuration in 2.6.7-rc3-mm1. The node_online_map is
> Rob> incorrect because of actions taken by reassign_cpu_only_nodes
> Rob> in arch/ia64/mm/discontig.c. The mm1 patch which changes the
> Rob> mempolicy for the init_task uses this invalid node_online_map
> Rob> and eventually uses a non-existent node's zonelist when calling
> Rob> __alloc_pages.
>
> The patch looks fine to me. If there are no objections from others, I
> shall be happy to apply it in my tree, if that's what you want me to
> do.
The node_online bitmap is already initialized to 0, isn't it? Oh no, I see.
arch_numa_init sets all the available nodes online, but then
reassign_cpu_nodes truncates that number. The patch looks ok to me.
Jesse
prev parent reply other threads:[~2004-06-10 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 15:23 [PATCH] discontig.c Robert Picco
2004-06-10 18:10 ` David Mosberger
2004-06-10 20:00 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406101300.20258.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox