Re: [PATCH 1/4] SGI Altix cross partition functionality

[Christoph Hellwig <hch@infradead.org>]

On Wed, Jun 16, 2004 at 12:40:53PM -0500, Robin Holt wrote:
> > > Index: linux/kernel/exit.c
> > > =================================> > > --- linux.orig/kernel/exit.c	Thu Jun 10 15:04:09 2004
> > > +++ linux/kernel/exit.c	Thu Jun 10 16:31:55 2004
> > > @@ -1184,6 +1184,7 @@ end_wait4:
> > >  	remove_wait_queue(&current->wait_chldexit,&wait);
> > >  	return retval;
> > >  }
> > > +EXPORT_SYMBOL(sys_wait4);
> > 
> > No way.  Calling syscalls from kernelspace is always a bad idea.  (And this
> > is not linux-ia64 material anyway)
> 
> How should a parent thread be reaping children?
> 
> > 
> > > Index: linux/kernel/sched.c
> > > =================================> > > --- linux.orig/kernel/sched.c	Thu Jun 10 16:30:39 2004
> > > +++ linux/kernel/sched.c	Thu Jun 10 16:31:55 2004
> > > @@ -2814,6 +2814,7 @@ asmlinkage long sys_sched_setscheduler(p
> > >  {
> > >  	return setscheduler(pid, policy, param);
> > >  }
> > > +EXPORT_SYMBOL(sys_sched_setscheduler);
> > 
> > Again, don't mess with scheduler paramters from your modules.
> 
> How should a kernel thread raise itself to real-time priority?

Answer to both:  it shouldn't