From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Tolentino <matthew.e.tolentino@intel.com>,
David Mosberger <davidm@hpl.hp.com>
Subject: Re: [PATCH] Add PCDP console detection support
Date: Sat, 26 Jun 2004 10:15:27 +0000 [thread overview]
Message-ID: <20040626111527.B21799@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200406251504.50579.bjorn.helgaas@hp.com>; from bjorn.helgaas@hp.com on Fri, Jun 25, 2004 at 03:04:50PM -0600
On Fri, Jun 25, 2004 at 03:04:50PM -0600, Bjorn Helgaas wrote:
> This moves the code from drivers/serial/8250_hcdp.[ch] to
> drivers/firmware/pcdp.[ch], since it's no longer 8250-specific.
> It also obsoletes CONFIG_SERIAL_8250_HCDP, replacing it with
> CONFIG_EFI_PCDP (which defaults to Y for ia64).
I'm happy with this. The only thing I spotted on a quick read through
was:
> +static void __init
> +setup_serial_console(int rev, struct pcdp_uart *uart)
> +{
> +#ifdef CONFIG_SERIAL_8250_CONSOLE
>...
> + if (uart->addr.address_space_id = ACPI_ADR_SPACE_SYSTEM_MEMORY) {
> + port.mapbase = uart->addr.address;
> + port.membase = ioremap(port.mapbase, 64);
What if ioremap fails (can it fail here?)
> + port.iotype = SERIAL_IO_MEM;
Should be UPIO_MEM please. Seems I missed this in the HCDP code...
> + } else if (uart->addr.address_space_id = ACPI_ADR_SPACE_SYSTEM_IO) {
> + port.iobase = uart->addr.address;
> + port.iotype = SERIAL_IO_PORT;
Likewise should be UPIO_PORT please.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-06-26 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-25 21:04 [PATCH] Add PCDP console detection support Bjorn Helgaas
2004-06-26 10:15 ` Russell King [this message]
2004-06-28 16:55 ` Bjorn Helgaas
2004-07-05 1:14 ` peterc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040626111527.B21799@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox