From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] define cpu_logical_id() always
Date: Mon, 28 Jun 2004 15:46:38 +0000 [thread overview]
Message-ID: <200406280946.38489.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200406211459.39151.bjorn.helgaas@hp.com>
On Friday 25 June 2004 6:50 pm, David Mosberger wrote:
> >>>>> On Mon, 21 Jun 2004 14:59:39 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:
>
> Bjorn> Define cpu_logical_id() even when !SMP. I added uses of this
> Bjorn> in some iosapic printk's, which broke the UP build.
>
> I'm OK with the patch per se, but since there is no existing use of
> the macro for UP, I'd prefer it to be added along with the UP-user(s).
> Otherwise, somebody may come along and clean up the "unused" macro.
I added the use (both UP and SMP) here:
http://linux.bkbits.net:8080/linux-2.5/cset%4040b2da7fhqIb6rDAZoyBMBhz_djWwg
It makes the IOSAPIC setup printk look like this:
+ printk(KERN_INFO "GSI %u (%s, %s) -> CPU %d (0x%04x) vector %d\n",
+ gsi, (trigger = IOSAPIC_EDGE ? "edge" : "level"),
+ (polarity = IOSAPIC_POL_HIGH ? "high" : "low"),
+ cpu_logical_id(dest), dest, vector);
This broke the UP build.
prev parent reply other threads:[~2004-06-28 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 20:59 [PATCH] define cpu_logical_id() always Bjorn Helgaas
2004-06-26 0:50 ` David Mosberger
2004-06-28 15:46 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406280946.38489.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox