From: Paul Jackson <pj@sgi.com>
To: akpm@osdl.org, David Mosberger <davidm@hpl.hp.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.helgaas@hp.com
Cc: Matt Tolentino <matthew.e.tolentino@intel.com>,
Russell King <rmk@arm.linux.org.uk>, Paul Jackson <pj@sgi.com>
Subject: [patch] Fix ia64 UPF_RESOURCES pcdp.c 2.6.7-mm5 build
Date: Sun, 04 Jul 2004 02:19:06 +0000 [thread overview]
Message-ID: <20040704021907.32029.98969.47514@sam.engr.sgi.com> (raw)
It looks like someone removed UPF_RESOURCES in remove-upf_resources.patch
in parallel with someone adding drivers/firmware/pcdp.c that references
UPF_RESOURCES.
In any event, trying to build a defconfig ia64 2.6.7-mm5 (which includes
CONFIG_SERIAL_8250=y in the .config) fails with:
================ CC drivers/firmware/pcdp.o
drivers/firmware/pcdp.c: In function `setup_serial_console':
drivers/firmware/pcdp.c:100: error: `UPF_RESOURCES' undeclared (first use in this function)
================
The following patch fixes this build error.
Someone with a certified clue needs to sign off on this.
I'm just typing blindly.
Signed-off-by: Paul Jackson <pj@sgi.com>
Index: 267mm5cpusetv4ia64/drivers/firmware/pcdp.c
=================================--- 267mm5cpusetv4ia64.orig/drivers/firmware/pcdp.c 2004-07-03 16:52:20.000000000 -0700
+++ 267mm5cpusetv4ia64/drivers/firmware/pcdp.c 2004-07-03 16:52:34.000000000 -0700
@@ -97,7 +97,7 @@ setup_serial_console(int rev, struct pcd
default: port.type = PORT_UNKNOWN; break;
}
- port.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF | UPF_RESOURCES;
+ port.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF;
if (uart_irq_supported(rev, uart)) {
port.irq = acpi_register_gsi(uart->gsi,
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next reply other threads:[~2004-07-04 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-04 2:19 Paul Jackson [this message]
2004-07-04 7:13 ` [patch] Fix ia64 UPF_RESOURCES pcdp.c 2.6.7-mm5 build Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040704021907.32029.98969.47514@sam.engr.sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox