From: Robin Holt <holt@sgi.com>
To: Christoph Hellwig <hch@infradead.org>, Robin Holt <holt@sgi.com>,
Jesse Barnes <jbarnes@engr.sgi.com>, Pat Gefre <pfg@sgi.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Altix I/O code re-org
Date: Thu, 22 Jul 2004 20:20:45 +0000 [thread overview]
Message-ID: <20040722202045.GA1177@lnx-holt.americas.sgi.com> (raw)
In-Reply-To: <20040722194231.GA16991@infradead.org>
On Thu, Jul 22, 2004 at 08:42:31PM +0100, Christoph Hellwig wrote:
> > PS: I found a few small problems with the bte code and will soon have
> > another patch that fixes that up. Specifically, there were changes
> > made to bte_error.c and pda.h that are undone by your patch.
>
> apropos bte, could you please merge bte_error.c into bte.c - there's no
> external callers of functions in bte_error.c except in bte.c
bte.c doesn't call bte_error. That used to get called from shub_iio_error()
or something like that. Would it be more appropriate to merge bte_error.c
into the callers file? I would lean towards putting it into bte.c, but
your previous add implied it should go into the callers file.
Thanks,
Robin
next prev parent reply other threads:[~2004-07-22 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-22 15:14 Altix I/O code re-org Pat Gefre
2004-07-22 17:55 ` Christoph Hellwig
2004-07-22 17:57 ` Jesse Barnes
2004-07-22 19:20 ` Robin Holt
2004-07-22 19:40 ` Robin Holt
2004-07-22 19:42 ` Christoph Hellwig
2004-07-22 20:20 ` Robin Holt [this message]
2004-07-22 20:29 ` Robin Holt
2004-07-22 20:52 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040722202045.GA1177@lnx-holt.americas.sgi.com \
--to=holt@sgi.com \
--cc=hch@infradead.org \
--cc=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox