From: Jack Steiner <steiner@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] - Update function prototype for sn_io_addr
Date: Fri, 23 Jul 2004 21:56:29 +0000 [thread overview]
Message-ID: <20040723215628.GA14272@sgi.com> (raw)
In-Reply-To: <20040723122907.GA7308@sgi.com>
On Fri, Jul 23, 2004 at 10:15:44AM -0700, David Mosberger wrote:
> >>>>> On Fri, 23 Jul 2004 07:29:08 -0500, Jack Steiner <steiner@sgi.com> said:
>
> Jack> Add "const" to function prototype for sn_io_addr. Cuts boot
> Jack> time on simulator in half.
>
> Jack> Signed-off-by: Jack Steiner <steiner@sgi.com>
>
> Jack> __attribute__ ((__const__));
>
> I think you're supposed to use __attribute_const__.
Right..
Add "const" to function prototype for sn_io_addr. Cuts boot time
on simulator in half.
Signed-off-by: Jack Steiner <steiner@sgi.com>
Index: linux/include/asm-ia64/sn/sn2/io.h
=================================--- linux.orig/include/asm-ia64/sn/sn2/io.h
+++ linux/include/asm-ia64/sn/sn2/io.h
@@ -8,10 +8,11 @@
#ifndef _ASM_SN_SN2_IO_H
#define _ASM_SN_SN2_IO_H
+#include <linux/compiler.h>
+#include <asm/intrinsics.h>
-extern void * sn_io_addr(unsigned long port); /* Forward definition */
+extern void * sn_io_addr(unsigned long port) __attribute_const__; /* Forward definition */
extern void sn_mmiob(void); /* Forward definition */
-#include <asm/intrinsics.h>
#define __sn_mf_a() ia64_mfa()
--
Thanks
Jack Steiner (steiner@sgi.com) 651-683-5302
Principal Engineer SGI - Silicon Graphics, Inc.
next prev parent reply other threads:[~2004-07-23 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 12:29 [PATCH] - Update function prototype for sn_io_addr Jack Steiner
2004-07-23 17:15 ` David Mosberger
2004-07-23 21:56 ` Jack Steiner [this message]
2004-07-24 7:05 ` Peter Chubb
2004-07-24 8:27 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040723215628.GA14272@sgi.com \
--to=steiner@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox