Re: Altix I/O code reorganization

Patrick Gefre
2004-08-11T23:24:43Z

I'm sending out a new patch set - the set of files will follow this email.

I'll add in this email the comments on the general comments and the comments on
the specific pach comments will be in the email for that updated patch - hopefully
that makes some kind of sense 8^). I didn't include the small bte change in this
set.

Christoph Hellwig wrote:
> On Wed, Aug 04, 2004 at 03:14:08PM -0500, Pat Gefre wrote:
>
>
> Yikes, this is truely horrible. First your patch ordering doesn't make
> any sense, with just the first patch applied the system won't work at all.
> Please submit a series of _small_ patches going from A to B keeping the code
> working everywhere inbetween.
>

This is a very BIG change. However, the BIG change ends up with
very little code in the kernel. The reason is because, we have enhanced the
functionalities in our Prom to actually configure and initialize all devices
in the system instead of just the BaseIO devices.

It is not practical to have small patches that will work independently.

The code base is now small enough that we should not have a problem
providing feedback.

> Your new directory structure is very bad. Just stick all files into
> arch/ia64/sn/io/ instead of adding subdirectories for often just a single
> file.
>

We do like our directory structures. It provides very logical
separation of code files.