Re: [PATCH 2/4] SGI Altix cross partition functionality (1st revision)

Christoph Hellwig
2004-09-04T11:15:37Z

> Please no magic numbers in logs. This always leads to customers calling
> support with the "what does 13 mean and should I be concerned"? If the
> community objects to the case statement above, then find a different
> way that implements the textual name.

So run a postprocessor over the log.

> I like keeping the lock protecting as little as possible. This has been
> drilled into peoples heads here at SGI since the early Cray days. We have
> always been told to keep locks protecting a single cohesive group of data.

And because of that IRIX isa huge mess with far too much locks :) Keep
it as simple as possible and optimize where optimization is needed.
Needless complexity is the root of all evil.