From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] fix CONFIG_DISCONTIGMEM and CONFIG_VIRTUAL_MEMMAP
Date: Sun, 05 Sep 2004 15:33:46 +0000 [thread overview]
Message-ID: <200409050833.46503.jbarnes@engr.sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
Looks like the patch that fixed Ian's problem introduced an ugly warning.
Maybe we could just switch to requiring CONFIG_DISCONTIGMEM and
CONFIG_VIRTUAL_MEMMAP for ia64 in general? That would let us kill a lot of
code and only have one code path, etc. Benchmarks have shown that the
overhead of CONFIG_DISCONTIGMEM is very difficult to measure (if you look at
the code, the only added overhead in any fast path is an additional pointer
dereference in alloc_pages). CONFIG_VIRTUAL_MEMMAP is a little more
expensive iirc, but still difficult to measure.
Jesse
[-- Attachment #2: virtual-memmap+discontig-fix.patch --]
[-- Type: text/x-diff, Size: 966 bytes --]
===== include/asm-ia64/page.h 1.27 vs edited =====
--- 1.27/include/asm-ia64/page.h 2004-09-02 22:25:57 -07:00
+++ edited/include/asm-ia64/page.h 2004-09-05 08:28:38 -07:00
@@ -89,11 +89,11 @@
# define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
# define page_to_pfn(page) ((unsigned long) (page - vmem_map))
# define pfn_to_page(pfn) (vmem_map + (pfn))
-# endif
-#else /* !CONFIG_VIRTUAL_MEM_MAP */
-#define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
-#define page_to_pfn(page) ((unsigned long) (page - mem_map))
-#define pfn_to_page(pfn) (mem_map + (pfn))
+# else /* !CONFIG_VIRTUAL_MEM_MAP */
+# define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
+# define page_to_pfn(page) ((unsigned long) (page - mem_map))
+# define pfn_to_page(pfn) (mem_map + (pfn))
+# endif /* CONFIG_VIRTUAL_MEMMAP */
#endif /* CONFIG_DISCONTIGMEM */
#define page_to_phys(page) (page_to_pfn(page) << PAGE_SHIFT)
next reply other threads:[~2004-09-05 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-05 15:33 Jesse Barnes [this message]
2004-09-06 2:11 ` [PATCH] fix CONFIG_DISCONTIGMEM and CONFIG_VIRTUAL_MEMMAP Ian Wienand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409050833.46503.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox