From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [RFC 1/2] Add SN2 Special Memory driver.
Date: Fri, 10 Sep 2004 07:35:21 +0000 [thread overview]
Message-ID: <20040910083521.B21519@infradead.org> (raw)
In-Reply-To: <20040909175339.GA23863@lnx-holt.americas.sgi.com>
On Thu, Sep 09, 2004 at 12:53:39PM -0500, Robin Holt wrote:
>
> Really, this is a 2 part patch and not a 4 part.
>
> Rename the fetchop.h to mspec.h.
>
> Index: linux-2.6/include/asm-ia64/sn/mspec.h
> =================================> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6/include/asm-ia64/sn/mspec.h 2004-08-31 12:13:43.000000000 -0500
> @@ -0,0 +1,85 @@
> +/*
> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License. See the file "COPYING" in the main directory of this archive
> + * for more details.
> + *
> + * Copyright (c) 2001-2003 Silicon Graphics, Inc. All rights reserved.
> + */
> +
> +#ifndef _ASM_IA64_SN_FETCHOP_H
> +#define _ASM_IA64_SN_FETCHOP_H
These don't match the filename.
> +
> +#include <linux/config.h>
> +
> +#define FETCHOP_BASENAME "sgi_fetchop"
> +#define FETCHOP_FULLNAME "/dev/sgi_fetchop"
This doesn't belong into a kernel header.
> +/*
> + * Convert a region 6 (kaddr) address to the address of the fetchop variable
> + */
> +#define FETCHOP_KADDR_TO_MSPEC_ADDR(kaddr) TO_MSPEC(kaddr)
Why this wrapper?
next prev parent reply other threads:[~2004-09-10 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 17:53 [RFC 1/2] Add SN2 Special Memory driver Robin Holt
2004-09-10 7:35 ` Christoph Hellwig [this message]
2004-09-10 8:00 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040910083521.B21519@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox