From: Andrew Morton <akpm@osdl.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: Unaligned kernel access in crypto/sha1.c
Date: Sat, 18 Sep 2004 05:11:08 +0000 [thread overview]
Message-ID: <20040917221108.32545506.akpm@osdl.org> (raw)
In-Reply-To: <20040916231638.GA32514@lucon.org>
"H. J. Lu" <hjl@lucon.org> wrote:
>
> I got
>
> Sep 16 15:45:32 gnu-2 kernel: kernel unaligned access to
> 0xa0000002001c008e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d005e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d006e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d007e, ip=0xa0000001002135e0
> Sep 16 15:45:37 gnu-2 kernel: kernel unaligned access to
> 0xa0000002002d008e, ip=0xa0000001002135e0
>
> on ia64 from sha1_transform in crypto/sha1.c:
>
> /* Hash a single 512-bit block. This is the core of the algorithm. */
> static void sha1_transform(u32 *state, const u8 *in)
> {
> u32 a, b, c, d, e;
> u32 block32[16];
>
> /* convert/copy data to workspace */
> for (a = 0; a < sizeof(block32)/sizeof(u32); a++)
> block32[a] = be32_to_cpu (((const u32 *)in)[a]);
> ^^^^^^^^^^^^^^^^
> This may not be aligned for u32 on ia64.
>
>
We really need to know the call trace here.
--- 25/arch/ia64/kernel/unaligned.c~ia64-alignment-error-stack-dump 2004-09-17 22:10:14.933111832 -0700
+++ 25-akpm/arch/ia64/kernel/unaligned.c 2004-09-17 22:10:35.903923784 -0700
@@ -1342,9 +1342,11 @@ ia64_handle_unaligned (unsigned long ifa
printk(KERN_WARNING "%s", buf); /* watch for command names containing %s */
}
} else {
- if (within_logging_rate_limit())
+ if (within_logging_rate_limit()) {
printk(KERN_WARNING "kernel unaligned access to 0x%016lx, ip=0x%016lx\n",
ifa, regs->cr_iip + ipsr->ri);
+ dump_stack();
+ }
set_fs(KERNEL_DS);
}
_
next prev parent reply other threads:[~2004-09-18 5:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 23:16 Unaligned kernel access in crypto/sha1.c H. J. Lu
2004-09-18 5:11 ` Andrew Morton [this message]
2004-09-20 18:16 ` H. J. Lu
2004-09-20 18:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040917221108.32545506.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hjl@lucon.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox