Re: [PATCH][3/4] Add hotplug support to drivers/acpi/numa.c

Keshavamurthy Anil S
2004-09-27T20:06:16Z

On Fri, Sep 24, 2004 at 01:32:55AM +0900, Keiichiro Tokunaga wrote:
> +void acpi_numa_node_init(acpi_handle handle)
Why is this function returning void? I expect
this to return int, what do you think?
> +
> + if (acpi_bus_get_device(handle, &node_dev)) {
> + printk(KERN_ERR"Unknown handle.\n");
> + return_VOID;
> + }
Why do you need to call acpi_bus_get_device?

> + acpi_walk_namespace(ACPI_TYPE_PROCESSOR,
> + handle,
> + (u32) 1,
> + find_processor,
> + data,
> + (void **)&cnt);
Why are you looking for processor device here?
Please remove this acpi_walk_namespace function.

> + /*
> diff -puN /dev/null include/acpi/numa.h
> +#ifndef MAX_PXM_DOMAINS
> +#define MAX_PXM_DOMAINS (256)
> +#endif
Why defining it again, It is already defined in asm-ia64/acpi.h file
>
> _