Re: [PATCH][1/4] Add unregister_node() to drivers/base/node.c

Keshavamurthy Anil S
2004-09-27T18:52:44Z

On Fri, Sep 24, 2004 at 01:31:23AM +0900, Keiichiro Tokunaga wrote:
>
> -int __init register_node(struct node *node, int num, struct node *parent)
> +int register_node(struct node *node, int num, struct node *parent)

__devinit please

> +void unregister_node(struct node *node, struct node *parent)

unregister_node is required only for hotplug case. Please hide this function
under suitable #ifdef's, say this is only required if CONFIG_HOTPLUG is enabled.

> + sysdev_remove_file(&node->sysdev, &attr_cpumap);
> + sysdev_remove_file(&node->sysdev, &attr_meminfo);

add sysdev_remove_file(&node->sysdev, &attr_numastat);

> +EXPORT_SYMBOL(node_online_map);
Why do you need this in this patch?