From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Date: Mon, 20 Sep 2004 20:57:53 +0000 Subject: Re: page fault scalability patch V8: [4/7] universally available cmpxchg on i386 Message-Id: <20040920205752.GH4242@wotan.suse.de> List-Id: References: <200409191430.37444.vda@port.imtp.ilyichevsk.odessa.ua> <200409202043.00580.vda@port.imtp.ilyichevsk.odessa.ua> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Lameter Cc: Denis Vlasenko , akpm@osdl.org, "David S. Miller" , benh@kernel.crashing.org, wli@holomorphy.com, davem@redhat.com, raybry@sgi.com, ak@muc.de, manfred@colorfullife.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, vrajesh@umich.edu, hugh@veritas.com On Mon, Sep 20, 2004 at 01:49:20PM -0700, Christoph Lameter wrote: > On Mon, 20 Sep 2004, Denis Vlasenko wrote: > > > I think it shouldn't be this way. > > > > OTOH for !CONFIG_386 case it makes perfect sense to have it inlined. > > Would the following revised patch be acceptable? You would need an EXPORT_SYMBOL at least. But to be honest your original patch was much simpler and nicer and cmpxchg is not called that often that it really matters. I would just ignore Denis' suggestion and stay with the old patch. -Andi