Re: [PATCH][4/4] Add NUMA node handling to the container driver

Keiichiro Tokunaga
2004-09-24T04:44:49Z

> Keiichiro Tokunaga wrote:
>
> >Name: container_for_numa.patch
> >Status: Tested on 2.6.9-rc2
> >Signed-off-by: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
> >Description:
> >Add NUMA node handling to the container driver.
> >
> >Thanks,
> >Keiichiro Tokunaga
> >---
> >@@ -198,6 +208,7 @@ container_device_add(struct acpi_device
> > if (acpi_bus_add(device, pdev, handle, ACPI_BUS_TYPE_DEVICE)) {
> > return_VALUE(-ENODEV);
> > }
> >+ container_numa_add((*device)->handle);
> >
> >
> Maybe that should be :
>
> container_numa_add(phandle);
>
> instead? Device is the child at this point.

Thanks for looking!

A container's handle needs to be passed to the function here.
The (*device)->handle is the handle. So there is no problem.
The phandle is just used for acpi_bus_add().

Thanks,
Keiichiro Tokunaga