From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Date: Mon, 27 Sep 2004 06:12:28 +0000 Subject: Re: [ACPI] PATCH-ACPI based CPU hotplug[2/6]-ACPI Eject interface support Message-Id: <200409270112.29422.dtor_core@ameritech.net> List-Id: References: <20040920092520.A14208@unix-os.sc.intel.com> <200409201812.45933.dtor_core@ameritech.net> <20040924162823.B27778@unix-os.sc.intel.com> In-Reply-To: <20040924162823.B27778@unix-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Keshavamurthy Anil S Cc: Len Brown , acpi-devel@lists.sourceforge.net, LHNS list , Linux IA64 , Linux Kernel On Friday 24 September 2004 06:28 pm, Keshavamurthy Anil S wrote: > +typedef void acpi_device_sysfs_files(struct kobject *, > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0const struct attribute *); > + > +static void setup_sys_fs_device_files(struct acpi_device *dev, > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0acpi_device_sysfs_files *fu= nc); > + > +#define create_sysfs_device_files(dev)=A0\ > +=A0=A0=A0=A0=A0=A0=A0setup_sys_fs_device_files(dev, (acpi_device_sysfs_f= iles *)&sysfs_create_file) > +#define remove_sysfs_device_files(dev)=A0\ > +=A0=A0=A0=A0=A0=A0=A0setup_sys_fs_device_files(dev, (acpi_device_sysfs_f= iles *)&sysfs_remove_file) Hi Anil, It looks very nice except for the part above. I am really confused what the purpose of this code is... It looks like it just complicates things? --=20 Dmitry