From: Tony Luck <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] clean up contig/discontig/virt_mem_map macros
Date: Mon, 27 Sep 2004 22:33:10 +0000 [thread overview]
Message-ID: <200409272233.i8RMXAV32176@unix-os.sc.intel.com> (raw)
I got this patch from Zou Nan hai to resolve the problem that
Andrew Morton has been having booting his ia64 system. The code
is quite a bit cleaner as he has reduced the number of different
definitions of pfn_valid/page_to_pfn/pfn_to_page, and left the
only remaining ones next to each other in page.h ... so this
should be easier to maintain going forward.
It has been tested on a variety of systems:
1G Tiger \ Tested by Zou Nan hai, I assume DIG=y, NUMA=n
8G Tiger / but I don't know for sure.
4G Tiger with generic_defconfig
4G Tiger with DIG kernel, NUMA, DISCONTIG and VIRTUAL_MEM_MAP on
4G Tiger with DIG kernel, NUMA/DISCONTIG off; VIRTUAL_MEM_MAP on
HP zx2000 with zx1_defconfig
Can someone please check it on sn2 (sn2_defconfig compiles, but I haven't
booted it) ... and any other systems or configurations that don't match
any of the above. I'd like to stop carrying the BPB that Andrew gave
me.
-Tony
diff -Nraup a/arch/ia64/mm/contig.c b/arch/ia64/mm/contig.c
--- a/arch/ia64/mm/contig.c 2004-09-12 22:32:00.000000000 -0700
+++ b/arch/ia64/mm/contig.c 2004-09-26 04:36:46.944608285 -0700
@@ -269,7 +269,6 @@ paging_init (void)
vmem_map = (struct page *) 0;
free_area_init_node(0, &contig_page_data, zones_size, 0,
zholes_size);
- mem_map = contig_page_data.node_mem_map;
} else {
unsigned long map_size;
@@ -280,11 +279,10 @@ paging_init (void)
vmem_map = (struct page *) vmalloc_end;
efi_memmap_walk(create_mem_map_page_table, 0);
- contig_page_data.node_mem_map = vmem_map;
+ mem_map = contig_page_data.node_mem_map = vmem_map;
free_area_init_node(0, &contig_page_data, zones_size,
0, zholes_size);
- mem_map = contig_page_data.node_mem_map;
printk("Virtual mem_map starts at 0x%p\n", mem_map);
}
#else /* !CONFIG_VIRTUAL_MEM_MAP */
diff -Nraup a/include/asm-ia64/mmzone.h b/include/asm-ia64/mmzone.h
--- a/include/asm-ia64/mmzone.h 2004-09-12 22:33:39.000000000 -0700
+++ b/include/asm-ia64/mmzone.h 2004-09-26 04:37:13.863553267 -0700
@@ -27,12 +27,6 @@
# define NR_NODE_MEMBLKS (NR_NODES * 4)
#endif
-extern unsigned long max_low_pfn;
-
-#define pfn_valid(pfn) (((pfn) < max_low_pfn) && ia64_pfn_valid(pfn))
-#define page_to_pfn(page) ((unsigned long) (page - vmem_map))
-#define pfn_to_page(pfn) (vmem_map + (pfn))
-
#else /* CONFIG_DISCONTIGMEM */
# define NR_NODE_MEMBLKS 4
#endif /* CONFIG_DISCONTIGMEM */
diff -Nraup a/include/asm-ia64/page.h b/include/asm-ia64/page.h
--- a/include/asm-ia64/page.h 2004-09-12 22:31:43.000000000 -0700
+++ b/include/asm-ia64/page.h 2004-09-26 04:36:59.530545630 -0700
@@ -84,17 +84,16 @@ extern int ia64_pfn_valid (unsigned long
#endif
#ifndef CONFIG_DISCONTIGMEM
-# ifdef CONFIG_VIRTUAL_MEM_MAP
+# define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
+# define page_to_pfn(page) ((unsigned long) (page - mem_map))
+# define pfn_to_page(pfn) (mem_map + (pfn))
+#else
extern struct page *vmem_map;
-# define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
-# define page_to_pfn(page) ((unsigned long) (page - vmem_map))
-# define pfn_to_page(pfn) (vmem_map + (pfn))
-# else
-# define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
-# define page_to_pfn(page) ((unsigned long) (page - mem_map))
-# define pfn_to_page(pfn) (mem_map + (pfn))
-# endif
-#endif /* CONFIG_DISCONTIGMEM */
+extern unsigned long max_low_pfn;
+# define pfn_valid(pfn) (((pfn) < max_low_pfn) && ia64_pfn_valid(pfn))
+# define page_to_pfn(page) ((unsigned long) (page - vmem_map))
+# define pfn_to_page(pfn) (vmem_map + (pfn))
+#endif
#define page_to_phys(page) (page_to_pfn(page) << PAGE_SHIFT)
#define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
next reply other threads:[~2004-09-27 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 22:33 Tony Luck [this message]
2004-09-27 23:17 ` [PATCH] clean up contig/discontig/virt_mem_map macros Jesse Barnes
2004-09-27 23:18 ` Keshavamurthy Anil S
2004-09-28 3:24 ` Darren Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409272233.i8RMXAV32176@unix-os.sc.intel.com \
--to=tony.luck@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox