From: Jesse Barnes <jbarnes@engr.sgi.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Pat Gefre <pfg@sgi.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization
Date: Tue, 05 Oct 2004 15:43:44 +0000 [thread overview]
Message-ID: <200410050843.44265.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <B8E391BBE9FE384DAA4C5C003888BE6F0221C647@scsmsx401.amr.corp.intel.com>
On Monday, October 4, 2004 10:13 pm, Luck, Tony wrote:
> I'm ok with the delete/add of most of the SGI
> specific files (maybe it still isn't perfect yet,
> but it may be close enough to take it, and then
> clean up with some small patches).
>
> But you seem to be touching some files outside of pure SGI
> stuff. These two are a bit of a concern:
>
> include/asm-ia64/io.h
Not sure about these changes...
> arch/ia64/pci/pci.c
It looks like the only non-codingstyle change here is to make pci_root_ops
non-static (and btw, some of the CodingStyle fixups look wrong). If it needs
to be non-static, it should be declared in a header file so we don't have to
extern it in sn_pci_fixup_bus.
Jesse
next prev parent reply other threads:[~2004-10-05 15:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 21:57 [PATCH] 2.6 SGI Altix I/O code reorganization Pat Gefre
2004-10-05 5:13 ` Luck, Tony
2004-10-05 15:43 ` Jesse Barnes [this message]
2004-10-05 16:22 ` Grant Grundler
2004-10-05 17:45 ` Matthew Wilcox
2004-10-05 19:00 ` Colin Ngam
2004-10-05 19:10 ` Grant Grundler
2004-10-05 19:15 ` Matthew Wilcox
2004-10-05 18:20 ` Patrick Gefre
2004-10-05 18:34 ` Jesse Barnes
2004-10-05 15:48 ` Christoph Hellwig
2004-10-05 18:26 ` Patrick Gefre
2004-10-05 23:30 ` Patrick Gefre
2004-10-05 15:50 ` Christoph Hellwig
2004-10-05 19:16 ` Luck, Tony
2004-10-05 19:35 ` Patrick Gefre
2004-10-05 20:34 ` Luck, Tony
2004-10-06 15:32 ` Patrick Gefre
2004-10-06 18:57 ` Grant Grundler
2004-10-06 19:09 ` Colin Ngam
2004-10-06 19:54 ` Grant Grundler
2004-10-06 19:54 ` Colin Ngam
2004-10-06 20:10 ` Patrick Gefre
2004-10-06 20:44 ` Jesse Barnes
2004-10-07 15:02 ` Patrick Gefre
2004-10-07 16:52 ` Jesse Barnes
2004-10-06 20:27 ` Jesse Barnes
2004-10-06 20:21 ` Colin Ngam
2004-10-06 20:33 ` Matthew Wilcox
2004-10-06 20:48 ` Grant Grundler
2004-10-06 21:05 ` Matthew Wilcox
2004-10-06 20:55 ` Colin Ngam
2004-10-08 15:16 ` Colin Ngam
2004-10-08 16:37 ` Jesse Barnes
2004-10-09 22:20 ` Grant Grundler
[not found] ` <4169A508.84FB19C7@sgi.com>
2004-10-11 14:03 ` Patrick Gefre
2004-10-08 22:37 ` Colin Ngam
2004-10-07 17:06 ` Luck, Tony
2004-10-07 17:22 ` Jesse Barnes
2004-10-07 18:59 ` Jes Sorensen
2004-10-11 20:49 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410050843.44265.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox