Re: [PATCH] 2.6 SGI Altix I/O code reorganization

Patrick Gefre
2004-10-07T15:02:41Z

Jesse Barnes wrote:
> On Wednesday, October 6, 2004 1:10 pm, Patrick Gefre wrote:
>
>>I don't plan on respinning the large patches (unless of course they get out
>>of date). It would be great to get the kill, add and qla patch in so we can
>>move forward and address some these other smaller issues - rather than
>>holding up the larger mods for them.
>
>
> I agree, but could you please just 'vi' the 002-add-files patch and remove
> these?
>
> drivers/char/mmtimer.c | 1
> drivers/char/snsc.c | 25
> drivers/ide/pci/sgiioc4.c | 23
> drivers/serial/sn_console.c | 214
>
> They should each be separate cleanup patches. What I've done in the past is
> make copies (in this case 5) of the big patch. Then I edit all of them to
> include only the hunks I want there. Hopefully that'll minimize the pain of
> respinning the big patch (i.e. no respin). Also, Tony doesn't want to deal
> with the above files, patches for them should be sent to Andrew as separate
> mails with lkml in the cc list.
>

These are not cleanup.

The mmtimer code and sn_console include a file that doesn't exist anymore in the directory included
- it's moved to somewhere else in the 002 patch.

snsc.c, sgiioc4.c have changes for things that won't exist after this patch is applied.