Re: [PATCH] 2.6 SGI Altix I/O code reorganization

Jesse Barnes
2004-10-05T18:34:55Z

On Tuesday, October 5, 2004 11:20 am, Patrick Gefre wrote:
> > These others are outside of my area (well I *might* push
> > the drivers that are only used by SGI ... but hotplug
> > and qla1280 are definitely not mine). So they need to be
> > split out into separate patches.
>
> As a general comment, the changes to these files are because of mods in the
> reorg code - so they are needed for this base but not in the older code.
> So, in my mind, it is a package - or should be taken as a whole. I can
> break them out, but I think they need to go together.

Yeah, that's fine, but it's easier to review and integrate if patches to
update the API are separate files and mails (e.g. 2/3, 3/3, etc.). Makes for
more detailed changelog comments and makes changes in the bk tree much easier
to track. In general, the smaller, the better.

> > drivers/char/mmtimer.c
>
> This is Jesse's code. We made an include file change. Is this OK Jesse ?

Yeah, that's fine.

> > drivers/ide/pci/sgiioc4.c
>
> More Lindent mods. We took out the endian code - not needed anymore.

Sounds like that could be a separate cleanup patch.

> > drivers/pci/hotplug/Kconfig
>
> Took out SGI PCI Hotplug. Since there isn't any code behind it - we will
> add it back in when we submit the code for it.

Sounds good, probably a separate patch too.

Thanks,
Jesse