public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [RFC] Convert pgtable cache to slab
Date: Wed, 13 Oct 2004 19:49:29 +0000	[thread overview]
Message-ID: <20041013194929.GA11320@lnx-holt.americas.sgi.com> (raw)
In-Reply-To: <yq1zn2qtpyo.fsf@wilson.mkp.net>

On Wed, Oct 13, 2004 at 03:32:43PM -0400, Martin K. Petersen wrote:
> >>>>> "Tony" = Luck, Tony <tony.luck@intel.com> writes:
> 
> Tony,
> 
> Tony> What was the benchmark you were running when you measured these?
> 
> I'm going to let Robin send you his test case.

Martin, can you send your updated test case.  I believe yours is just mine
with a higher resolution timer.  If you are uncomfortable with that, let
me know.

> 
> 
> Tony> How does this scale on big sn2 systems? I assume that the
> Tony> answers are going to be just fine as the slab allocator per-cpu
> Tony> lists should be just as nice as local quicklists, but it would
> Tony> be nice to see some data.
> 
> The tests above are from a 64-way Altix.
> 
> I'm still looking into the issue of freed data ending up in other
> nodes' slabs.  Don't know if anybody else have been working on this?

When I tried to measure these on a large multi-threaded job, the difference
got lost in the noise.

> 
> 
> >> The biggest caveat is that I've had to postpone setting up the gate
> >> page until the pgt slab has been initialized.  That wasn't an issue
> >> with the existing page-based allocation scheme.  David - how do you
> >> prefer I handle this?
> 
> Tony> I don't see the code for this postponement in this patch.
> 
> It's there.  End of the mm/init.c hunk.
> 
> 
> Tony> Perhaps "zero_cache" isn't as descriptive a name as it might be
> Tony> (not that I have any better suggestions :-(
> 
> Yeah, this is what Bill called it on ppc64.  pgtable_cache perhaps?

If we are renaming things, can we rename zero_ctor to something a little
more sensible.
> 
> -- 
> Martin K. Petersen	Wild Open Source, Inc.
> mkp@wildopensource.com	http://www.wildopensource.com/
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2004-10-13 19:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-13 18:47 [RFC] Convert pgtable cache to slab Martin K. Petersen
2004-10-13 18:57 ` Jesse Barnes
2004-10-13 18:59 ` William Lee Irwin III
2004-10-13 19:07 ` Luck, Tony
2004-10-13 19:28 ` Jesse Barnes
2004-10-13 19:32 ` Martin K. Petersen
2004-10-13 19:32 ` Luck, Tony
2004-10-13 19:42 ` Martin K. Petersen
2004-10-13 19:49 ` Robin Holt [this message]
2004-10-13 19:50 ` Robin Holt
2004-10-13 20:23 ` Luck, Tony
2004-10-13 20:34 ` Martin K. Petersen
2004-10-13 20:37 ` Martin K. Petersen
2004-10-14  7:44 ` David Mosberger
2004-10-14 10:27 ` William Lee Irwin III
2004-10-14 11:00 ` David Mosberger
2004-10-14 11:07 ` Robin Holt
2004-10-14 11:10 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041013194929.GA11320@lnx-holt.americas.sgi.com \
    --to=holt@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox