From: Jesse Barnes <jbarnes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Double spin_unlock in bte.c
Date: Thu, 14 Oct 2004 21:00:32 +0000 [thread overview]
Message-ID: <200410141600.33141.jbarnes@sgi.com> (raw)
In-Reply-To: <20041014114003.GF19122@lnx-holt.americas.sgi.com>
Tony, I don't think there's any hurry on this one, so you can just send it
along post-2.6.9 if you want. Hopefully it won't conflict with Pat's big sn2
patches.
Acked-by: Jesse Barnes <jbarnes@sgi.com>
On Thursday, October 14, 2004 6:40 am, Robin Holt wrote:
> If all bte interfaces are in use, the current code will leave the
> bte pointer set when exiting from the loop trying to locate an
> interface to use. This results in two processes using the same
> interface and both trying to free the same one. With a
> premptible kernel, this results in the preempt count getting
> off.
>
> Signed-off-by: Robin Holt
>
>
> Index: linux-2.6/arch/ia64/sn/kernel/bte.c
> =================================> --- linux-2.6.orig/arch/ia64/sn/kernel/bte.c 2004-10-06 11:48:25.000000000
> -0500 +++ linux-2.6/arch/ia64/sn/kernel/bte.c 2004-10-14 06:34:45.000000000
> -0500 @@ -131,12 +131,12 @@
> (BTE_LNSTAT_LOAD(bte) & BTE_ACTIVE)) {
> /* Got the lock but BTE still busy */
> spin_unlock(&bte->spinlock);
> - bte = NULL;
> } else {
> /* we got the lock and it's not busy */
> break;
> }
> }
> + bte = NULL;
> }
>
> if (bte != NULL) {
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2004-10-14 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 11:40 Double spin_unlock in bte.c Robin Holt
2004-10-14 21:00 ` Jesse Barnes [this message]
2004-10-15 5:18 ` Luck, Tony
2004-10-18 17:02 ` Pat Gefre
2004-10-18 21:34 ` Robin Holt
2004-10-19 19:45 ` Pat Gefre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410141600.33141.jbarnes@sgi.com \
--to=jbarnes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox