From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 14 Oct 2004 18:00:06 +0000 Subject: Re: [PATCH] Introduce PCI <-> CPU address conversion [1/2] Message-Id: <20041014180005.GA11954@infradead.org> List-Id: References: <20041014124737.GM16153@parcelfarce.linux.theplanet.co.uk> <20041014125348.GA9633@infradead.org> <20041014135323.GO16153@parcelfarce.linux.theplanet.co.uk> In-Reply-To: <20041014135323.GO16153@parcelfarce.linux.theplanet.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: Christoph Hellwig , Greg KH , linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org On Thu, Oct 14, 2004 at 02:53:23PM +0100, Matthew Wilcox wrote: > On Thu, Oct 14, 2004 at 01:53:48PM +0100, Christoph Hellwig wrote: > > I'd rather have this declared in every architectures asm/ header, so it's > > more explicit that it's an per-arch thing. Also make it a static inline > > so we get typechecking. > > I actually don't want typechecking. Sometimes you have a device and > sometimes you have a bus. You can get everything you want (sysdata) > from either, so there's no point in doing dev->bus when all you needed > was right there. For some architectures the sysdata is different for bus vs device, so yes, we do want strict typechecking.