From: Matthew Wilcox <matthew@wil.cx>
To: Colin Ngam <cngam@sgi.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
Christoph Hellwig <hch@infradead.org>, Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Introduce PCI <-> CPU address conversion [1/2]
Date: Fri, 15 Oct 2004 00:36:33 +0000 [thread overview]
Message-ID: <20041015003633.GX16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <416EFFBE.7B8F702@sgi.com>
On Thu, Oct 14, 2004 at 05:37:51PM -0500, Colin Ngam wrote:
> On SGI's Altix system, the sysdata for the device is very much different than
> the sysdata for the bus.
That's fascinating, because ia64 is one of the architectures that relies
on sysdata being the same in both the bus and the device:
#define PCI_CONTROLLER(busdev) ((struct pci_controller *) busdev->sysdata)
In various places, we have
struct pci_controller *controller = PCI_CONTROLLER(dev);
and
if (PCI_CONTROLLER(bus)->iommu)
So what the hell does Altix do? Which sysdata can be used to get to the
pci_controller? This seems like a horrible mistake to me.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-10-15 0:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 12:47 [PATCH] Introduce PCI <-> CPU address conversion [1/2] Matthew Wilcox
2004-10-14 12:53 ` Christoph Hellwig
2004-10-14 13:53 ` Matthew Wilcox
2004-10-14 18:00 ` Christoph Hellwig
2004-10-14 18:07 ` Matthew Wilcox
2004-10-14 22:37 ` Colin Ngam
2004-10-15 0:36 ` Matthew Wilcox [this message]
2004-10-14 14:27 ` Ivan Kokshaysky
2004-10-14 14:39 ` Matthew Wilcox
2004-10-15 7:19 ` Richard Henderson
2004-10-15 10:34 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041015003633.GX16153@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=cngam@sgi.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox