From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Date: Tue, 16 Nov 2004 17:01:49 +0000 Subject: Re: [PATCH] fix phys. address conversion in ia64_pal_tr_read Message-Id: <200411160901.49769.jbarnes@engr.sgi.com> List-Id: References: <200411151722.41157.jbarnes@engr.sgi.com> In-Reply-To: <200411151722.41157.jbarnes@engr.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org On Monday, November 15, 2004 6:03 pm, David Mosberger wrote: > >>>>> On Mon, 15 Nov 2004 17:22:41 -0800, Jesse Barnes > >>>>> said: > > Jesse> The palinfo module may call ia64_pal_tr_read using an IPI. > Jesse> If the processor receiving the IPI is idle, the call will > Jesse> fail since the idle process stack is in region 5 and > Jesse> ia64_pal_tr_read uses __pa rather than ia64_tpa. This small > Jesse> patch fixes the problem by making it use ia64_tpa instead. > > Perhaps its worthwhile to do any audit for this kind of problems? It > may not be very difficult to hack sparse to add a check for __pa() > calls on (stack-)local variables. I didn't see anything obvious in a quick check of all the ia64 users of __pa (they were mostly referring to stuff in the static data section), but I may have missed something. Jesse