public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: VM_LOCKED in pci_mmap_page_range?
Date: Sat, 20 Nov 2004 00:07:34 +0000	[thread overview]
Message-ID: <200411191607.34798.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <200411191557.55922.jbarnes@engr.sgi.com>

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

On Friday, November 19, 2004 3:57 pm, Jesse Barnes wrote:
> Should pci_mmap_page_range marked the pages as VM_LOCKED that it's about to
> request be remapped via remap_pfn_range?  I'm seeing userspace apps hang on
> mmaping of /proc/bus/pci unless I remove it.

I just read the thread "loops in get_user_pages() for VM_IO" on lkml and it 
appears that VM_LOCKED shouldn't be set for IO mappings.  Or is this fixed 
upstream and I haven't updated my tree?  If not, then this fixes it for me.

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Thanks,
Jesse

[-- Attachment #2: pci-mmap-reserved-fix.patch --]
[-- Type: text/plain, Size: 469 bytes --]

===== arch/ia64/pci/pci.c 1.59 vs edited =====
--- 1.59/arch/ia64/pci/pci.c	2004-11-05 11:55:25 -08:00
+++ edited/arch/ia64/pci/pci.c	2004-11-19 16:01:45 -08:00
@@ -518,7 +518,7 @@
 	 * Leave vm_pgoff as-is, the PCI space address is the physical
 	 * address on this platform.
 	 */
-	vma->vm_flags |= (VM_SHM | VM_LOCKED | VM_IO);
+	vma->vm_flags |= (VM_SHM | VM_RESERVED | VM_IO);
 
 	if (write_combine)
 		vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);

      reply	other threads:[~2004-11-20  0:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19 23:57 VM_LOCKED in pci_mmap_page_range? Jesse Barnes
2004-11-20  0:07 ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200411191607.34798.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox