From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [RFC] I/O error handling for userspace
Date: Mon, 06 Dec 2004 22:56:58 +0000 [thread overview]
Message-ID: <200412061456.59040.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <200412030831.25662.jbarnes@engr.sgi.com>
On Monday, December 6, 2004 9:05 am, Jesse Barnes wrote:
> This is the only bit I'm unsure about. I can't just add a spin_trylock
> version, since the call path for send_sig_info calls the slab allocator,
> which takes other locks.
>
> Assuming that only the CPU that caused the MCA is in the MCA handler
> (i.e. rendezvous doesn't occur), then the only time that one of the
> spinlocks could hang is if the current CPU also owned it, right? Hmm,
> maybe the ia64_spinlock_contention routine could check for a machine
> check condition and promote the failure to an uncorrectable one in that
> case? That's pretty ugly though...
This is tricky. If we want I/O error handling to be 100% reliable when I/O
errors are caused by userspace applications, we need to deal with the case
where the offending process' machine check is received in either user or
kernel mode, regardless of what context we're currently in. My code assumes
that we receive the machine check in user mode and so the force_sig_info is
safe, but obviously that won't always be the case.
We need to do a few things in order to ensure safety (this should apply to the
double bit memory error case too I think):
o make sure the process doesn't run until we've tried to recover from the
error
o don't take any locks while we're in machine check context
o don't destroy our current context since we may want to resume to it
eventually (esp. in the case where we received the machine check in kernel
context)
So, given the above, maybe we could put the process in a TASK_STOPPED state
and pend a scheduler tick on the CPU where we took the machine check? At
that point, we could also wake up an MCA worker thread or raise an MCA
interrupt (maybe using the NMI interrupt vector, it's high priority and isn't
used right now) to send the signal or do whatever cleanup was needed.
Jesse
next prev parent reply other threads:[~2004-12-06 22:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-03 16:31 [RFC] I/O error handling for userspace Jesse Barnes
2004-12-03 16:43 ` Jesse Barnes
2004-12-06 12:42 ` Hidetoshi Seto
2004-12-06 16:13 ` Jesse Barnes
2004-12-06 16:59 ` Jesse Barnes
2004-12-06 17:05 ` Jesse Barnes
2004-12-06 22:56 ` Jesse Barnes [this message]
2004-12-06 23:51 ` Keith Owens
2004-12-07 0:38 ` Keith Owens
2004-12-07 0:40 ` Jesse Barnes
2004-12-07 1:29 ` Keith Owens
2004-12-07 1:36 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412061456.59040.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox