From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Date: Sun, 12 Dec 2004 20:41:17 +0000 Subject: Re: [2.6 patch] ia64 smpboot.c: remove an unused function Message-Id: <20041212204117.GV22324@stusta.de> List-Id: References: <20041212193921.GA22324@stusta.de> <41BCAE31.7030702@hp.com> In-Reply-To: <41BCAE31.7030702@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Picco Cc: David Mosberger-Tang , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Dec 12, 2004 at 03:46:41PM -0500, Robert Picco wrote: > Adrian Bunk wrote: > > >The patch below removes an unused global functions. > > > > > >Signed-off-by: Adrian Bunk > > > >--- linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c.old 2004-12-12 > >02:51:04.000000000 +0100 > >+++ linux-2.6.10-rc2-mm4-full/arch/ia64/kernel/smpboot.c 2004-12-12 > >02:51:18.000000000 +0100 > >@@ -356,11 +356,6 @@ > > return cpu_idle(); > >} > > > >-struct pt_regs * __devinit idle_regs(struct pt_regs *regs) > >-{ > >- return NULL; > >-} > >- > >struct create_idle { > > struct task_struct *idle; > > struct completion done; > > > > > > > I don't believe this is unused. At least not in 2.6.10-rc3. fork_idle > requires this function. Ups sorry, you are correct. For some strange reason I missed. > Bob Thanks for the correction Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed