Re: [PATCH] add legacy I/O and memory access routines to /proc/bus/pci API

Andreas Dilger
2004-12-15T21:03:46Z

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On Dec 15, 2004 09:27 -0800, Jesse Barnes wrote:
> +write
> + Legacy I/O port space reads and writes must also be to a file
> + position >64k--the kernel will route them to the target device.

Shouldn't that be < 64k based on the description of lseek?

> +lseek
> + Can be used to set the current file position. Note that the file
> + size is limited to 64k as that's how big legacy I/O space is.

> +ioctl
> + Note that not all architectures support the *_MMAP_* or *_RW_* ioctl
> + commands. If they're not supported, ioctl will return -EINVAL.

Shouldn't they return -ENOTTY? That indicates to the caller that the
ioctl isn't handled, vs -EINVAL which indicates bad value being passed
(e.g. bad write size).

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]