From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: linux-pci@atrey.karlin.mff.cu, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
bjorn.helgaas@hp.com
Subject: Re: [PATCH] add legacy I/O and memory access routines to /proc/bus/pci API
Date: Wed, 15 Dec 2004 23:15:51 +0000 [thread overview]
Message-ID: <200412151515.51450.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <20041215210346.GK9923@schnapps.adilger.int>
On Wednesday, December 15, 2004 1:03 pm, Andreas Dilger wrote:
> On Dec 15, 2004 09:27 -0800, Jesse Barnes wrote:
> > +write
> > + Legacy I/O port space reads and writes must also be to a file
> > + position >64k--the kernel will route them to the target device.
>
> Shouldn't that be < 64k based on the description of lseek?
Err.. yes
> > +lseek
> > + Can be used to set the current file position. Note that the file
> > + size is limited to 64k as that's how big legacy I/O space is.
> >
> > +ioctl
> > + Note that not all architectures support the *_MMAP_* or *_RW_* ioctl
> > + commands. If they're not supported, ioctl will return -EINVAL.
>
> Shouldn't they return -ENOTTY? That indicates to the caller that the
> ioctl isn't handled, vs -EINVAL which indicates bad value being passed
> (e.g. bad write size).
Maybe, but that's not how /proc/bus/pci behaves right now...
Jesse
prev parent reply other threads:[~2004-12-15 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-14 17:41 [PATCH] add legacy I/O and memory access routines to /proc/bus/pci API Jesse Barnes
2004-12-14 23:55 ` Bjorn Helgaas
2004-12-15 0:11 ` Jesse Barnes
2004-12-15 3:06 ` Jesse Barnes
2004-12-15 8:57 ` [PATCH] add legacy I/O and memory access routines to Benjamin Herrenschmidt
2004-12-15 17:00 ` [PATCH] add legacy I/O and memory access routines to /proc/bus/pci API Jesse Barnes
2004-12-16 14:55 ` [PATCH] add legacy I/O and memory access routines to Benjamin Herrenschmidt
2004-12-16 16:26 ` [PATCH] add legacy I/O and memory access routines to /proc/bus/pci API Jesse Barnes
2004-12-15 17:27 ` Jesse Barnes
2004-12-15 21:03 ` Andreas Dilger
2004-12-15 23:15 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412151515.51450.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=adilger@clusterfs.com \
--cc=benh@kernel.crashing.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox