Re: [PATCH] add legacy I/O port & memory APIs to /proc/bus/pci

Jesse Barnes
2004-12-16T17:04:46Z

On Thursday, December 16, 2004 8:56 am, Christoph Hellwig wrote:
> On Thu, Dec 16, 2004 at 08:50:19AM -0800, Jesse Barnes wrote:
> > This patch documents the /proc/bus/pci interface and adds some optional
> > architecture specific APIs for accessing legacy I/O port and memory
> > space. This is necessary on platforms where legacy I/O port space doesn't
> > 'soft fail' like it does on PCs, and is useful for systems that can route
> > legacy space to different PCI busses.
>
> Please don't add more interfaces to procfs. And ioctl() on procfs is even
> more evil.

Oh come on, there's already an API there, and now it's documented even! The
additions are straightforward and there's no where else to put them... /sys
doesn't seem like a good place either, would you prefer a device driver?

I really don't see what the problem is though. /proc/bus/pci is a commonly
used API and I don't see it going away. These extensions just make it a
little more usable on platforms like sn2 and ppc.

Jesse