From: Matthew Wilcox <matthew@wil.cx>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] Perfmon over-initialises its inodes
Date: Sun, 19 Dec 2004 05:24:53 +0000 [thread overview]
Message-ID: <20041219052453.GC7113@parcelfarce.linux.theplanet.co.uk> (raw)
i_sb and i_sock are both initialised by alloc_inode().
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Index: linux/arch/ia64/kernel/perfmon.c
=================================RCS file: /var/cvs/linux-2.6/arch/ia64/kernel/perfmon.c,v
retrieving revision 1.20
diff -u -p -r1.20 perfmon.c
--- linux/arch/ia64/kernel/perfmon.c 4 Dec 2004 07:02:04 -0000 1.20
+++ linux/arch/ia64/kernel/perfmon.c 19 Dec 2004 05:22:28 -0000
@@ -2160,9 +2160,7 @@ pfm_alloc_fd(struct file **cfile)
DPRINT(("new inode ino=%ld @%p\n", inode->i_ino, inode));
- inode->i_sb = pfmfs_mnt->mnt_sb;
inode->i_mode = S_IFCHR|S_IRUGO;
- inode->i_sock = 0;
inode->i_uid = current->fsuid;
inode->i_gid = current->fsgid;
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
reply other threads:[~2004-12-19 5:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041219052453.GC7113@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox