From: Russ Anderson <rja@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] per cpu MCA/INIT fixes.
Date: Thu, 06 Jan 2005 20:50:12 +0000 [thread overview]
Message-ID: <200501062050.j06KoCL0218437@ben.americas.sgi.com> (raw)
In-Reply-To: <200501060308.j0638M7s194286@ben.americas.sgi.com>
Tony Luck wrote:
>
> I just applied and pushed Jack's patch to the test-2.6.11 tree, Russ, can
> you fix up your patch to apply cleanly on top of Jack's.
Yup.
> >> +#ifdef CONFIG_SMP
> >> +#include <asm/mca.h>
> >> +#endif
> >
> >Just a nit, header files should always be safe to include
> >unconditionally. If they're not, the headers need fixing (barring out of tree
> >stuff like kdb of course).
>
> Agreed ... this looks really ugly ... surely we want to support MCA
> on uni-processors as well as SMP! What's the issue that provoked
> adding the #ifdef here?
The only reason was that the changes are all in per_cpu_init() and
that routine is inside #ifdef CONFIG_SMP.
I built the patch with all configs in arch/ia64/configs, but now
see that they all have CONFIG_SMP=y. (sigh)
Given all the infrastructure setup done under #ifdef CONFIG_SMP, would
it work with uni-processor? I'll start digging through the code...
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com
next prev parent reply other threads:[~2005-01-06 20:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 3:08 [patch] per cpu MCA/INIT fixes Russ Anderson
2005-01-06 17:14 ` Jesse Barnes
2005-01-06 18:21 ` Russ Anderson
2005-01-06 18:28 ` Luck, Tony
2005-01-06 18:36 ` Jesse Barnes
2005-01-06 20:50 ` Russ Anderson [this message]
2005-01-06 23:17 ` Russ Anderson
2005-01-07 6:51 ` Luck, Tony
2005-01-07 7:08 ` Luck, Tony
2005-01-07 17:47 ` Bjorn Helgaas
2005-01-07 18:56 ` Luck, Tony
2005-01-07 19:28 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501062050.j06KoCL0218437@ben.americas.sgi.com \
--to=rja@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox