From: Russ Anderson <rja@efs.americas.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ia64: reset console_loglevel so INIT output always goes to
Date: Sun, 09 Jan 2005 16:24:37 +0000 [thread overview]
Message-ID: <200501091624.j09GObm6046175@efs.americas.sgi.com> (raw)
In-Reply-To: <1105140871.25267.50.camel@eeyore>
Bjorn Helgaas wrote:
>
> Reset console_loglevel early in INIT handler. Otherwise, if
> it has been turned down (i.e., with "dmesg -n1"), the user may
> see no effect at all from issuing an INIT. We're never going
> to run any more user code, so there won't be any opportunity for
> anything to collect the output from the dmesg buffer.
As Keith pointed out, we are working on returning from an INIT.
Would it be reasonable to save the current console_loglevel,
set console_loglevel up to 15, call init_handler_platform(), and
then set console_loglevel back to the original level?
Right now init_handler_platform() never returns. When the code
is improved to return, the console_loglevel will get restored
to the correct level.
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> === arch/ia64/kernel/mca.c 1.71 vs edited ==> --- 1.71/arch/ia64/kernel/mca.c 2004-11-11 11:04:30 -07:00
> +++ edited/arch/ia64/kernel/mca.c 2005-01-07 16:22:54 -07:00
> @@ -1133,6 +1133,7 @@
> pal_min_state_area_t *ms;
>
> oops_in_progress = 1; /* avoid deadlock in printk, but it makes recovery dodgy */
> + console_loglevel = 15; /* make sure printks make it to console */
>
> printk(KERN_INFO "Entered OS INIT handler. PSP=%lx\n",
> ia64_sal_to_os_handoff_state.proc_state_param);
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com
next prev parent reply other threads:[~2005-01-09 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 23:34 [PATCH] ia64: reset console_loglevel so INIT output always goes to Bjorn Helgaas
2005-01-08 1:32 ` [PATCH] ia64: reset console_loglevel so INIT output always goes to console Keith Owens
2005-01-09 16:24 ` Russ Anderson [this message]
2005-01-09 17:06 ` Russ Anderson
2005-01-09 23:26 ` Keith Owens
2005-01-10 4:27 ` [PATCH] ia64: reset console_loglevel so INIT output always Bjorn Helgaas
2005-01-10 7:54 ` [PATCH] ia64: reset console_loglevel so INIT output always goes to console Matthias Fouquet-Lapar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501091624.j09GObm6046175@efs.americas.sgi.com \
--to=rja@efs.americas.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox