From: Jesse Barnes <jbarnes@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: fixing 2.6.10 UP builds
Date: Thu, 13 Jan 2005 00:50:13 +0000 [thread overview]
Message-ID: <200501121650.13730.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <20050106201427.GA6009@jale>
On Wednesday, January 12, 2005 4:34 pm, Luck, Tony wrote:
> >> arch/ia64/sn/kernel/sn2/sn_hwperf.c: In function `sn_hwperf_op_cpu':
> >> arch/ia64/sn/kernel/sn2/sn_hwperf.c:360: warning: implicit declaration
> >> of function `smp_call_function_single'
> >
> >Looks like we need a !CONFIG_SMP version of smp_call_function_single.
> >include/linux/smp.h has a non-smp version of smp_call_function
> >that just returns 0, should smp_call_function_single do the same thing?
>
> That would make the warning go away, but it isn't obvious to me
> that you'd end up with code that did the right thing. Looking
> at the bigger picture, just what is sn_hwperf_op_cpu() supposed
> to do in the UP case?
It's supposed to make a SAL call for the CPU specified in the op_arg. Seems
like smp_call_function_single should make the specified call unconditionally
on CPU 0?
Jesse
next prev parent reply other threads:[~2005-01-13 0:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 20:14 fixing 2.6.10 UP builds dann frazier
2005-01-06 21:31 ` Luck, Tony
2005-01-06 21:36 ` Christoph Hellwig
2005-01-06 21:54 ` Jesse Barnes
2005-01-06 21:59 ` Luck, Tony
2005-01-08 3:02 ` dann frazier
2005-01-13 0:02 ` Luck, Tony
2005-01-13 0:20 ` Jesse Barnes
2005-01-13 0:34 ` Luck, Tony
2005-01-13 0:36 ` Christoph Lameter
2005-01-13 0:50 ` Jesse Barnes [this message]
2005-01-13 0:55 ` Mark Goodwin
2005-01-13 1:42 ` Mark Goodwin
2005-01-13 8:14 ` Christoph Hellwig
2005-01-13 19:11 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501121650.13730.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox