Re: pgprot_writecombine & shub 1.x

Jesse Barnes
2005-01-11T22:35:36Z

On Tuesday, January 11, 2005 2:12 pm, David Mosberger wrote:
> This seems wrong to me. pgprot_writecombine() should do what it says,
> no more and no less.
>
> The EFI memory-map has already all the info needed to determine
> whether write-combine mapping is supported, so perhaps the code should
> be changed to take that into consideration instead?

But what about places that unconditionally set the WC bit regardless of what
the EFI memory map says? pci_mmap_page_range does this for example if the
write_combine flag is set on the vma. I'm looking for a way to abstract out
uses like that, so that shub 1.x systems don't set the bit.

Jesse