public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [patch] ia64: fix potential NaT bit error for sys_pipe().
Date: Mon, 24 Jan 2005 19:32:27 +0000	[thread overview]
Message-ID: <200501241932.j0OJWRg06230@unix-os.sc.intel.com> (raw)
In-Reply-To: <16878.2168.388519.26567@napali.hpl.hp.com>

>>>>> On Thu, 20 Jan 2005 19:32:48 -0800, Chen, Kenneth W
  Ken> We would rather not to change THREAD_FLAGS_TO_CLEAR definition.
  Ken> mfh bit in child pt_regs is cleared right above where the
  Ken> comment is.  I think it is better as is so that child thread
  Ken> fph partition stays invalidated.

David Mosberger Monday, January 24, 2005 11:18 AM
> Sorry, I was a bit in a rush when I typed that mail and made some
> errors as a result.  I think what you propose is reasonable, since
> just clearing PSR.MFH will take care of avoiding needless
> context-switching of f32-f127.  However, I think it'd still be
> worthwhile to update the comment in copy_thread() to reflect this
> thinking (basically, the paragraph starting with "XXX" would have to
> be updated).

Absolutely agreeing with updating the comments.  Also in a way, what
you said earlier also make sense.  Since clearing psr.mfh is only half
of the optimization.  That would only optimize away the storing part
of context switch.  However, if later we take a dfh fault, if thread fph
valid bit is on, we end up loading from memory instead of a simple zeroing.
So I better do both, clearing psr.mfh and fph valid bit in thread.flags.

- Ken



  parent reply	other threads:[~2005-01-24 19:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19  7:12 [patch] ia64: fix potential NaT bit error for sys_pipe() David Mosberger
2005-01-20 17:52 ` David Mosberger
2005-01-20 19:00 ` Seth, Rohit
2005-01-20 23:22 ` Seth, Rohit
2005-01-20 23:51 ` David Mosberger
2005-01-21  3:32 ` Chen, Kenneth W
2005-01-21 18:48 ` Chen, Kenneth W
2005-01-24  6:40 ` David Mosberger
2005-01-24 19:17 ` David Mosberger
2005-01-24 19:32 ` Chen, Kenneth W [this message]
2005-01-24 19:43 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501241932.j0OJWRg06230@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox