Re: [patch -mm series] ia64 specific /dev/mem handlers

Andrew Morton
2005-02-22T19:25:13Z

Matthew Wilcox <matthew@wil.cx> wrote:
>
> On Tue, Feb 22, 2005 at 09:41:04AM -0500, Jes Sorensen wrote:
> > >> + if (page->flags & PG_uncached)
> >
> > Andrew> dude. That ain't gonna work ;)
> >
> > Pardon my lack of clue, but why not?

if (page->flags & (1<<PG_uncached))

would have been correcter.

> I think you're supposed to always use test_bit() to check page flags

Yup. Add PageUncached macros to page-flags.h.