From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Fri, 04 Mar 2005 22:57:10 +0000 Subject: Re: [PATCH/RFC] I/O-check interface for driver's error handling Message-Id: <20050304225710.GB2647@elf.ucw.cz> List-Id: References: <422428EC.3090905@jp.fujitsu.com> <20050301165904.GN28741@parcelfarce.linux.theplanet.co.uk> <200503010910.29460.jbarnes@engr.sgi.com> <20050304135429.GC3485@openzaurus.ucw.cz> <1109975846.5680.305.camel@gaston> In-Reply-To: <1109975846.5680.305.camel@gaston> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Benjamin Herrenschmidt Cc: Jesse Barnes , linux-pci@atrey.karlin.mff.cuni.cz, Matthew Wilcox , Linus Torvalds , Jeff Garzik , Hidetoshi Seto , Linux Kernel list , linux-ia64@vger.kernel.org, Linas Vepstas , "Luck, Tony" Hi! > > Hmm, before we go async way (nasty locking, no?) could driver simply > > ask "did something bad happen while I was sleeping?" at begining of each > > function? > > > > For DMA problems, driver probably has its own, timer-based, > > "something is wrong" timer, anyway, no? > > No, there is no nasty locking, when the callback happens, pretty much > all IOs have stopped anyway due to errors, and we aren't on a critical > code path. What prevents driver from being run on another CPU, maybe just doing mdelay() between hardware accesses? Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!