From: Andrew Morton <akpm@osdl.org>
To: linux-ia64@vger.kernel.org
Subject: msi build error on ia64
Date: Sat, 12 Mar 2005 10:25:01 +0000 [thread overview]
Message-ID: <20050312022501.252adeb7.akpm@osdl.org> (raw)
Doing a `make allmodconfig' with Linus's latest tree:
drivers/built-in.o(.text+0x10302): In function `msi_init':
drivers/pci/msi.c:373: undefined reference to `pci_msi_quirk'
drivers/built-in.o(.text+0x10320):drivers/pci/msi.c:373: undefined reference to `pci_msi_quirk'
This is because drivers/pci/quirks.c:pci_msi_quirk is only defined if
CONFIG_X86_IO_APIC, but msi_init() unconditionally uses it.
Is this fix appropriate?
--- 25/drivers/pci/pci.h~ia64-msi-build-fix Sat Mar 12 18:13:37 2005
+++ 25-akpm/drivers/pci/pci.h Sat Mar 12 18:14:23 2005
@@ -64,8 +64,13 @@ extern void pci_remove_legacy_files(stru
/* Lock for read/write access to pci device and bus lists */
extern spinlock_t pci_bus_lock;
-extern int pcie_mch_quirk;
+#ifdef CONFIG_X86_IO_APIC
extern int pci_msi_quirk;
+#else
+#define pci_msi_quirk 0
+#endif
+
+extern int pcie_mch_quirk;
extern struct device_attribute pci_dev_attrs[];
extern struct class_device_attribute class_device_attr_cpuaffinity;
_
reply other threads:[~2005-03-12 10:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050312022501.252adeb7.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox