From: Andrew Morton <akpm@osdl.org>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, davidm@hpl.hp.com, hch@lst.de
Subject: Re: Fix irq_affinity write from /proc for IPF
Date: Mon, 14 Mar 2005 23:59:23 +0000 [thread overview]
Message-ID: <20050314155923.4847aea3.akpm@osdl.org> (raw)
In-Reply-To: <20050314155004.A22573@unix-os.sc.intel.com>
Ashok Raj <ashok.raj@intel.com> wrote:
>
> Hi Andrew/Tony
>
> This patch is required for IPF to perform deferred write to rte's when
> affinity is programmed via /proc. These entries can only be programmed when
> interrupt is pending.
"ia64" is preferred, please. Nobody knows what an IPF is.
>
> release_dir-araj/arch/ia64/kernel/irq.c | 12 ++++++++++--
> release_dir-araj/kernel/irq/proc.c | 10 ++++++++--
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff -puN arch/ia64/kernel/irq.c~fix_ia64_smp_affinity arch/ia64/kernel/irq.c
> --- release_dir/arch/ia64/kernel/irq.c~fix_ia64_smp_affinity 2005-03-14 14:35:44.589293491 -0800
> +++ release_dir-araj/arch/ia64/kernel/irq.c 2005-03-14 15:27:54.262106715 -0800
> @@ -94,12 +94,20 @@ skip:
> /*
> * This is updated when the user sets irq affinity via /proc
> */
> -cpumask_t __cacheline_aligned pending_irq_cpumask[NR_IRQS];
> +static cpumask_t __cacheline_aligned pending_irq_cpumask[NR_IRQS];
> static unsigned long pending_irq_redir[BITS_TO_LONGS(NR_IRQS)];
>
> -static cpumask_t irq_affinity [NR_IRQS] = { [0 ... NR_IRQS-1] = CPU_MASK_ALL };
> static char irq_redir [NR_IRQS]; // = { [0 ... NR_IRQS-1] = 1 };
>
> +/*
> + * Arch specific routine for deferred write to iosapic rte to reprogram
> + * intr destination.
> + */
> +void proc_set_irq_affinity(unsigned int irq, cpumask_t mask_val)
> +{
> + pending_irq_cpumask[irq] = mask_val;
> +}
> +
> void set_irq_affinity_info (unsigned int irq, int hwid, int redir)
> {
> cpumask_t mask = CPU_MASK_NONE;
> diff -puN kernel/irq/proc.c~fix_ia64_smp_affinity kernel/irq/proc.c
> --- release_dir/kernel/irq/proc.c~fix_ia64_smp_affinity 2005-03-14 14:41:05.475031747 -0800
> +++ release_dir-araj/kernel/irq/proc.c 2005-03-14 15:27:59.436911339 -0800
> @@ -19,6 +19,13 @@ static struct proc_dir_entry *root_irq_d
> */
> static struct proc_dir_entry *smp_affinity_entry[NR_IRQS];
>
> +void __attribute__((weak))
> +proc_set_irq_affinity(unsigned int irq, cpumask_t mask_val)
> +{
> + irq_affinity[irq] = mask_val;
> + irq_desc[irq].handler->set_affinity(irq, mask_val);
> +}
> +
Is it not possible for ia64's ->set_affinity() handler to do this deferring?
next prev parent reply other threads:[~2005-03-14 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 23:50 Fix irq_affinity write from /proc for IPF Ashok Raj
2005-03-14 23:59 ` Andrew Morton [this message]
2005-03-15 0:23 ` Ashok Raj
2005-03-15 1:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314155923.4847aea3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=davidm@hpl.hp.com \
--cc=hch@lst.de \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox