From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Wed, 30 Mar 2005 13:40:49 +0000 Subject: Re: [PATCH] Pageset Localization V2 Message-Id: <20050330134049.GA21986@parcelfarce.linux.theplanet.co.uk> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Lameter Cc: Manfred Spraul , Andrew Morton , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mm@kvack.org, shai@scalex86.org On Tue, Mar 29, 2005 at 09:51:08PM -0800, Christoph Lameter wrote: > + BUG_ON(process_zones(smp_processor_id())); No. Who told you this was a good idea? This is the *worst* kind of assert, calling a function with side-effects. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain