Re: [mpm@selenic.com: Re: buggy ia64_fls() ? (was Re: /dev/random

Andrew Morton
2005-04-08T18:02:47Z

Matt Mackall <mpm@selenic.com> wrote:
>
> One wonders if:
>
> return ia64_getf_exp(d) & 0x3f;
>
> is the right fix.

Yes, that'll give the right result for fls(-1). But what'll it give for
fls(-2)?

> The fact that it's using floating point is... weird.
>
> Work around broken IA64 fls.

I'd be more inclined to make ia64 use generic_fls() until someone can get
in there and fix it for real.