RE: write_unlock: replace clear_bit with byte store

Chen, Kenneth W
2005-04-29T01:48:34Z

Chen, Kenneth W wrote on Thursday, April 28, 2005 6:04 PM
> Christoph Lameter wrote on Thursday, April 28, 2005 5:51 PM
>
> > +static inline void _raw_write_unlock(rwlock_t *x) {
> > + barrier();
> > + x->write_lock = 0;
> > +}
> > +
> > #endif /* !ASM_SUPPORTED */
>
> This portion is broken, where is the release semantics for updating
> the lock variable? Or where is the smp_mb() if you decide to use an
> unordered store for the lock variable?

Oops, never mind. Missed the portion that write_lock is declared as
volatile. My bad. This code is OK.