Re: write_unlock: replace clear_bit with byte store

David Mosberger
2005-04-29T11:37:25Z

>>>>> On Thu, 28 Apr 2005 13:53:11 -0700 (PDT), Christoph Lameter <clameter@engr.sgi.com> said:

Christoph> I thought that a memory barrier was needed to insure that
Christoph> the clearing of the lock becomes visible after changes
Christoph> done in the critical section?

With "volatile", the compiler will generate stX.rel...

Christoph> y is defined in its own block.

Ummh, macros 101: think about what happens for _raw_write_unlock(y)...

--david