From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Kenneth W" Date: Fri, 29 Apr 2005 01:04:00 +0000 Subject: RE: write_unlock: replace clear_bit with byte store Message-Id: <200504290104.j3T141g12260@unix-os.sc.intel.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org Christoph Lameter wrote on Thursday, April 28, 2005 5:51 PM > +static inline void _raw_write_unlock(rwlock_t *x) { > + barrier(); > + x->write_lock = 0; > +} > + > #endif /* !ASM_SUPPORTED */ This portion is broken, where is the release semantics for updating the lock variable? Or where is the smp_mb() if you decide to use an unordered store for the lock variable?