Re: Incorrect return types for atomic64 functions in IA64 atomic.h

Jerry Feldman
2005-04-29T19:39:12Z

On Friday 29 April 2005 3:10 pm, Andreas Schwab wrote:
> Jerry Feldman <gerald.feldman@hp.com> writes:
> > @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
> > return atomic_add_return(i, v) < 0;
> > }
> >
> > -static __inline__ int
> > +static __inline__ __s64
> > atomic64_add_negative (__s64 i, atomic64_t *v)
> > {
> > return atomic64_add_return(i, v) < 0;
>
> This is wrong. The return value is a boolean.
I agree. Should I resubmit the patch corrected, or will someone else do it.