Re: Incorrect return types for atomic64 functions in IA64 atomic.h

Andreas Schwab
2005-04-29T19:10:50Z

Jerry Feldman <gerald.feldman@hp.com> writes:

> @@ -124,7 +124,7 @@ atomic_add_negative (int i, atomic_t *v)
> return atomic_add_return(i, v) < 0;
> }
>
> -static __inline__ int
> +static __inline__ __s64
> atomic64_add_negative (__s64 i, atomic64_t *v)
> {
> return atomic64_add_return(i, v) < 0;

This is wrong. The return value is a boolean.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."