From: Greg Edwards <edwardsg@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH]: IA64: sparse cleanup of shub_mmr.h
Date: Mon, 09 May 2005 16:39:17 +0000 [thread overview]
Message-ID: <20050509163917.GF18250@sgi.com> (raw)
In-Reply-To: <427F5247.4000309@sgi.com>
On Mon, May 09, 2005 at 08:06:31AM -0400, Prarit Bhargava wrote:
| This patch is a sparse compile cleanup of shub_mmr.h using both the
| defconfig and the sn2_defconfig config files.
I'm getting rejects on current Tony's/Linus' git trees. Want to rediff?
...
| Index: arch/ia64/sn/kernel/sn2/ptc_deadlock.S
| =================================| --- e220183081409fe4c5d1961cf1e56d93a91d7efc/arch/ia64/sn/kernel/sn2/ptc_deadlock.S (mode:100644 sha1:7947312801eccc797975e338af4e76f12ace0c55)
| +++ deed0faf877ef4aa0feb36fcde2b044a77a73b4c/arch/ia64/sn/kernel/sn2/ptc_deadlock.S (mode:100644 sha1:96cb71d156820f9b33df9a07ea5049afe3bc77b9)
| @@ -6,6 +6,7 @@
| * Copyright (C) 2000-2004 Silicon Graphics, Inc. All rights reserved.
| */
|
| +#include <asm/types.h>
| #include <asm/sn/shub_mmr.h>
Shouldn't this be moved to include/asm-ia64/sn/shub_mmr.h, since
that's where we're referencing __IA64_UL_CONST?
Greg
next prev parent reply other threads:[~2005-05-09 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 12:06 [PATCH]: IA64: sparse cleanup of shub_mmr.h Prarit Bhargava
2005-05-09 16:39 ` Greg Edwards [this message]
2005-05-09 18:12 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050509163917.GF18250@sgi.com \
--to=edwardsg@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox