Re: [patch 3/4] ia64 SPARSEMEM - conditional changes for SPARSEMEM

[Bob Picco <bob.picco@hp.com>]

Jesse Barnes wrote:	[Mon May 23 2005, 02:14:48PM EDT]
> On Monday, May 23, 2005 10:51 am, Bob Picco wrote:
> > This patch introduces the conditional changes required for the three
> > memory models.  With [patch 1/4] there are three memory model
> > FLATMEM, DISCONTIG and SPARSEMEM.  Also a new arch include file
> > sparemem.h is introduced for defining SPARSEMEM parameters.
> 
> This looks like a good start at untangling CONFIG_DISCONTIGMEM and 
> CONFIG_NUMA.  Yay!
> 
> > -#ifdef CONFIG_VIRTUAL_MEM_MAP
> > +#ifdef	CONFIG_VIRTUAL_MEM_MAP
> 
> You can drop this hunk, right?
Yup.
> 
> >  extern int ia64_pfn_valid (unsigned long pfn);
> > -#else
> > +#elif	CONFIG_FLATMEM
> 
> Space instead of tab?
Yup.
> 
> >  # define ia64_pfn_valid(pfn) 1
> >  #endif
> >
> > -#ifndef CONFIG_DISCONTIGMEM
> > +#ifdef	CONFIG_FLATMEM
> 
> Ditto, and a few more later.
> 
> > -#define __pa(x)		({ia64_va _v; _v.l = (long) (x); _v.f.reg = 0;
> > _v.l;}) -#define __va(x)		({ia64_va _v; _v.l = (long) (x); _v.f.reg > > -1; _v.p;}) +#define __pa(x)	({							\
> > +	ia64_va _v; 							\
> > +	_v.l = (long) (x); 						\
> > +	_v.f.reg = 0; 							\
> > +	_v.l;								\
> > +})
> > +#define __va(x)	({							\
> > +	ia64_va _v;							\
> > +	_v.l = (long) (x);						\
> > +	_v.f.reg = -1;							\
> > +	_v.p;								\
> > +})
> 
> This looks like unrelated (but good) cleanup.  Should probably be 
> submitted separately along with similar cleanups for the other macros 
> (e.g. REGION_NUMBER, REGION_OFFSET).
Okay. I'll revert and do a separate cleanup later.
> 
> > +/* until we think of something better */
> > +#define	page_is_ram(pfn)	1
> 
> This macro could consult the EFI memory map (maybe only returning true 
> if the page was WB enabled?).  Does it have to be fast?
Arg.  This is extraneous.  I think it was required to stub around hotplug
memory simulation.  I'll remove.
> 
> Jesse
thanks,

bob