From: Andy Whitcroft <apw@shadowen.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] - SPARSEMEM - Change pfn to unsigned long
Date: Fri, 03 Jun 2005 14:53:28 +0000 [thread overview]
Message-ID: <20050603145328.GA19217@shadowen.org> (raw)
In-Reply-To: <20050601164102.GA15563@sgi.com>
Seems we arn't using unsigned long everywhere in sparsemem. Tested on
my test boxes. Thanks to Jack for finding this.
Andrew please apply to -mm.
-apw
== 8< =The latest 2.6.12-rc5-mm2 will not boot on large SGI systems. "pfn"
was assigned to an "int". Large systems overflow an int.
Trivial fix & it works ok now.....
Signed-off-by: Jack Steiner <steiner@sgi.com>
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
diffstat sparsemem-change-pfn-to-unsigned-long
---
page_alloc.c | 4 ++--
sparse.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff -upN reference/mm/page_alloc.c current/mm/page_alloc.c
--- reference/mm/page_alloc.c
+++ current/mm/page_alloc.c
@@ -1731,8 +1731,8 @@ void __init memmap_init_zone(unsigned lo
unsigned long start_pfn)
{
struct page *page;
- int end_pfn = start_pfn + size;
- int pfn;
+ unsigned long end_pfn = start_pfn + size;
+ unsigned long pfn;
for (pfn = start_pfn; pfn < end_pfn; pfn++, page++) {
if (!early_pfn_valid(pfn))
diff -upN reference/mm/sparse.c current/mm/sparse.c
--- reference/mm/sparse.c
+++ current/mm/sparse.c
@@ -124,7 +124,7 @@ void sparse_init(void)
* set. If this is <=0, then that means that the passed-in
* map was not consumed and must be freed.
*/
-int sparse_add_one_section(int start_pfn, int nr_pages, struct page *map)
+int sparse_add_one_section(unsigned long start_pfn, int nr_pages, struct page *map)
{
struct mem_section *ms = __pfn_to_section(start_pfn);
prev parent reply other threads:[~2005-06-03 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 16:41 [PATCH] - SPARSEMEM - Change pfn to unsigned long Jack Steiner
2005-06-03 14:53 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603145328.GA19217@shadowen.org \
--to=apw@shadowen.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox