From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Thu, 09 Jun 2005 17:20:35 +0000 Subject: Re: [PATCH 03/10] IOCHK interface for I/O error handling/detecting Message-Id: <20050609172035.GD24611@parcelfarce.linux.theplanet.co.uk> List-Id: References: <42A8386F.2060100@jp.fujitsu.com> <42A83B6D.8010703@jp.fujitsu.com> In-Reply-To: <42A83B6D.8010703@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hidetoshi Seto Cc: Linux Kernel list , linux-ia64@vger.kernel.org, Linas Vepstas , Benjamin Herrenschmidt , long , linux-pci@atrey.karlin.mff.cuni.cz, linuxppc64-dev On Thu, Jun 09, 2005 at 09:51:57PM +0900, Hidetoshi Seto wrote: > + switch (dev->hdr_type) { > + case PCI_HEADER_TYPE_NORMAL: /* 0 */ > + pci_read_config_word(dev, PCI_STATUS, &status); > + break; > + case PCI_HEADER_TYPE_BRIDGE: /* 1 */ > + pci_read_config_word(dev, PCI_SEC_STATUS, &status); > + break; > + case PCI_HEADER_TYPE_CARDBUS: /* 2 */ > + default: > + BUG(); If somebody plugs a cardbus card into an ia64 machine, we BUG()? Unacceptable. Just return 0 if you don't know what to do with a particular device. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain