From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Thu, 09 Jun 2005 17:34:33 +0000 Subject: Re: [PATCH 00/10] IOCHK interface for I/O error handling/detecting Message-Id: <20050609173433.GE24611@parcelfarce.linux.theplanet.co.uk> List-Id: References: <42A8386F.2060100@jp.fujitsu.com> In-Reply-To: <42A8386F.2060100@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hidetoshi Seto Cc: Linux Kernel list , linux-ia64@vger.kernel.org, Linas Vepstas , Benjamin Herrenschmidt , long , linux-pci@atrey.karlin.mff.cuni.cz, linuxppc64-dev On Thu, Jun 09, 2005 at 09:39:11PM +0900, Hidetoshi Seto wrote: > Reflecting every comments, I brushed up my patch for generic part. > So today I'll post it again, and also post "ia64 part", which > surely implements ia64-arch specific error checking. I think > latter will be a sample of basic implement for other arch. I think this is the wrong way to go about it. For PCI Express, we have a defined cross-architecture standard which tells us exactly how all future PCIe devices will behave in the face of errors. For PCI and PCI-X, we have a lot of legacy systems, each of which implements error checking and recovery in a somewhat eclectic way. So, IMO, any implementation of PCI error recovery should start by implementing the PCI Express AER mechanisms and then each architecture can look at extending that scheme to fit their own legacy hardware systems. That way we have a clean implementation for the future rather than being tied to any one manufacturer or architecture's quirks. Also, we can evaluate it based on looking at what the standard says, rather than all trying to wrap our brains around the idiosyncracies of a given platform ;-) -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain